Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortest Distance Between Words #1685 #1692

Merged
merged 6 commits into from
Dec 28, 2020

Conversation

ErzaTitania-2001
Copy link
Contributor

Have you read the Contributing Guidelines on Pull Requests?

yes

Description

(Write your answer here.)

Checklist

  • [ y] I've read the contribution guidelines.
  • [ y] I've checked the issue list before deciding what to submit.
  • [ y] I've edited the README.md and link to my code.

Related Issues or Pull Requests

Shortest Distance Between Words #1685 as assigned by @shraddhavp

@ErzaTitania-2001
Copy link
Contributor Author

@iamrajiv.


Scanner sc = new Scanner(System.in);
System.out.println("Enter the list of words " + "\n" + "Words = ");
arr = new ArrayList < > ();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove spaces between <>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plazzy99 done

@vatsalkesarwani12 vatsalkesarwani12 marked this pull request as ready for review December 26, 2020 09:21
Copy link
Contributor

@vatsalkesarwani12 vatsalkesarwani12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link
Contributor

@atarax665 atarax665 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comments wherever needed, it will help people to understand the approach used.


List < String > wd = new ArrayList(arr);
while (t > 0) {
String wd1 = sc.next();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prompt user to enter the words between which the distance is to be determined.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atarax665 done.

Added Comment lines
Prompted user to enter the words between which the distance is to be determined
@ErzaTitania-2001
Copy link
Contributor Author

@iamrajiv what is DeepSource error?

@iamrajiv
Copy link
Contributor

@ErzaTitania-2001 DeepSource is a code analysis tool. Do not worry about that. It is yet to be set for repository properly.

@iamrajiv iamrajiv merged commit 2bdd98f into HarshCasper:master Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants