Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider API Adjustment to Use Interfaces Rather Than Abstract Classes #175

Closed
Mike-E-angelo opened this issue Oct 17, 2016 · 3 comments
Closed

Consider API Adjustment to Use Interfaces Rather Than Abstract Classes #175

Mike-E-angelo opened this issue Oct 17, 2016 · 3 comments
Labels
area: core Issues that address the core abstractions & the wrappers state: needs discussion Issues that need further discussion

Comments

@Mike-E-angelo
Copy link

Cool project. :) Thank you for keeping it current.

Checking this out just now. It appears there are files such as DirectoryInfoBase and FileInfoBase. Has there been any thought towards making these interfaces instead, So IDirectoryInfo and IFileInfo? That way we're really abstracting the goodness and don't have to pass implementations around.

Thank you for any consideration!
@DavidArno
Copy link

DavidArno commented Nov 2, 2016 •
edited
Loading

Just found a link to this project, looked at the code and saw the same thing and thought the same thing.

This could be a really good project, but it's difficult to take it seriously when it uses abstract classes and inheritance, rather than interfaces. I'm happy to fix and do a PR if you'd like?

@MCCoolMoDAue
Copy link

I looked at some classes, and mostly the abstract classes are unnecessary.
Introducing interfaces should be straight forward.

@jpreese jpreese changed the title Discussion: Consider API Adjustment to Use Interfaces Rather Than Abstract Classes Consider API Adjustment to Use Interfaces Rather Than Abstract Classes Jul 7, 2018
@jpreese jpreese added the state: needs discussion Issues that need further discussion label Jul 7, 2018
@fgreinacher fgreinacher mentioned this issue Sep 28, 2018
Closed
@fgreinacher fgreinacher mentioned this issue Mar 11, 2019
Merged
@fgreinacher fgreinacher added the area: core Issues that address the core abstractions & the wrappers label Mar 24, 2019
@fgreinacher
Copy link
Contributor

Implemented by #452

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: core Issues that address the core abstractions & the wrappers state: needs discussion Issues that need further discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@DavidArno @MCCoolMoDAue @fgreinacher @Mike-E-angelo @jpreese