-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code compliance checks #214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File structure
The .conf
files and parser.py
are placed in the assets
directory, however, we don't need them inside the container. I think it would make more sense to move the code-check
directory in the parent dir, in the sources
dir and place the necessary files in it as follows
code-check
├── tree-sitter-parser.py
└── tree-sitter.conf.d
├── add-aliases.conf
├── add-history.conf
├── add-test-command.conf
├── add-to-list.conf
└── colorecho.conf
Workflow structure
The code check seems to be called by entrypoint_pull_request.yml
only. Let's move this content in a sub_code_check.yml
file and nest in the other entrypoints: pull requests, nightly, prerelease
Did most changes except changing the rust and cargo setup with |
Merging, nice job here |
Description
#215
A whitelisting feature is also present when the function is not required with :
# CODE-CHECK-WHITELIST=add-aliases