Fix windapsearch #67
Merged
Fix windapsearch #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 2, 2022 17:07
|
Thank you! Switched the PR to the |
ShutdownRepo
added
enhancement
|
Oh! Startkiller was already fixed on the dev branch. This is approximately the same method, but not in the same order. I'm not expert to say which one is the most efficient. |
|
Indeed, let's remove your fix to starkiller then, but I'd be happy to keep the fix for windapsearch |
ShutdownRepo
approved these changes
Nov 3, 2022
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that windapsearch and starkiller were not correctly installed. Here is the fix :)