-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: authentication support for proxies #1682
Comments
There's not much work involved in negotiating authentication in SOCKS. You should add support for a comma seperated list of IP:port for NO_PROXY. |
@iphydf Great I missed that. Can you add a comment to the PR the say what the state of the PR is and what it needs to be merged? Once it lands I can easily modify my testrunner to support SOCKS username and password https://git.plastiras.org/emdee/toxygen_wrapper/src/branch/main/src/tox_wrapper/tests/tests_wrapper.py |
Carrying over from irungentoo#1268.
Clients have gotten requests to support authenticated proxies, e.g.:
JFreegman/toxic#371
qTox/qTox#1286
I recognize that as nurupoo mentioned the authentication isn't encrypted with SOCKS5, but we've still had a few duplicate issues for qTox alone, and at least corporate proxies seems like a reasonable use case.
The text was updated successfully, but these errors were encountered: