Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: recognise/parse units from recipes correctly #163

Open
inos-github opened this issue May 13, 2023 · 1 comment
Open

Feature request: recognise/parse units from recipes correctly #163

inos-github opened this issue May 13, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@inos-github
Copy link

inos-github commented May 13, 2023

Sometimes, the unit of a product is parsed as a part of the product name.
Here some examples:
Screenshot_2023-05-13-12-41-15-638_org mozilla fennec_fdroid
Screenshot_2023-05-13-12-41-07-432_com tombursch kitchenowl

TL and EL are not recognised as units.
Additionally, however that's a second issue, the parsing of the description in parentheses is not consistent. It should be always a description and not part of the name.

second example:
Screenshot_2023-05-13-12-46-46-458_org mozilla fennec_fdroid
Screenshot_2023-05-13-12-46-54-455_com tombursch kitchenowl

TL and Pck. are not recognised as units.

Thanks for your efforts!!!

Extra information and references

No response

@inos-github inos-github added the enhancement New feature or request label May 13, 2023
@TomBursch
Copy link
Owner

I'm aware that it's not working perfectly. I'm using this (https://github.com/strangetom/ingredient-parser) library for parsing the ingredients. I will have to look into this a bit more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Ready for Testing
Development

No branches or pull requests

2 participants