Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ScreenInit events to Mixin so they fire reliably even on Neo/Forge #127

Open
BlayTheNinth opened this issue Feb 22, 2025 · 0 comments
Open

Move ScreenInit events to Mixin so they fire reliably even on Neo/Forge #127

BlayTheNinth opened this issue Feb 22, 2025 · 0 comments
Labels
Breaking Change This issue requires a breaking change to the API or ingame behavior Feature New features or improvements to existing features

Comments

@BlayTheNinth
Copy link
Member

BlayTheNinth commented Feb 22, 2025 •
edited
Loading

On some screens (like OptionsScreen or others that override repositionWidgets) Neo/Forge only fire screen init events the first time the screen is opened, and not on resizes. This makes the event near unusable on those screens, since it's impossible to reliably reposition custom buttons on resizes.

Fabric always fires screen init events.

Currently, Balm mixins into OptionsScreen to manually fire init events, but that doesn't cover other (vanilla/modded) screens using layouts or similar.
@BlayTheNinth BlayTheNinth added Breaking Change This issue requires a breaking change to the API or ingame behavior Feature New features or improvements to existing features labels Feb 22, 2025
@BlayTheNinth BlayTheNinth moved this to 📧 On Hold in Issues Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking Change This issue requires a breaking change to the API or ingame behavior Feature New features or improvements to existing features
Projects
Issues
Status: 📧 On Hold
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BlayTheNinth