-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No errors thrown while build running in the console. #319
Comments
That is just webpack output, the output of |
@phryneas Hi! Here is my minimal webpack config:
|
The problem here is that it doesn't show any output after build at all. |
Hmm. Could you make sure that you are running from the |
I'm having a similar issue, but i am still investigating to provide better input. However, here is my observation so far. We are using I suspect that in Now in It's still just a quick guess deduced from a recent observation. Maybe someone can confirm or disproof my suspicion. |
without a reliable repro it's hard to help. I suggest you take this setup here: https://github.com/TypeStrong/ts-loader/tree/master/examples/fork-ts-checker-webpack-plugin and try to reproduce the issue. |
i understand but can not reproduce it in a small setup so far and can not share the current project. Our setup involves
However if i remove the I checked our CI history and compared the commits where the behaviour occured the first time. Noticeable dependency changes were
But Our old webpack config was exported as an object
the new config is exported as an array for parallel builds
switching back to a single object export (just removing the monaco bundle) fixes the misbehaviour and the stats output and error log is back again. As i said, i can not reproduce it in a small project. Tried to mimic the setup in https://github.com/TypeStrong/ts-loader/tree/master/examples/fork-ts-checker-webpack-plugin but had no lick so far. |
In my case, I can't see plugin output on the first run, because console is cleared. So I see only build result, like "Ok. Ready at: localhost:8080" but errors go before this printing. So I can see them later when I change some files and rebuild triggered... |
Also seeing this behavior. We recently cleaned up a ton of tslint warnings and I suspect the forked process is finished BEFORE the webpack process and the last process is winning the display. |
Same issue. |
It can - I'm using it with babel-loader. Can you provide a reproducible? |
My issue looks the same as @giniedp I haven't figured out exactly how to handle this. I'll see if any of the newer versions are more permissive in not swallowing errors. If that doesn't work, I'll either fork it, or I'll just remove it completely and use Not sure if the issue is actually the same, but if you're running a custom build script you might want to look into this. |
@BiosBoy , @giniedp , @maksnester , @cmoad , @azizhk , @bfricka |
The same error when using version 5.0.1. |
Having the same issue, running Seems to completely ignore it at all (output from speed measure);
|
I am having a similar issue. @Aaron-Bird I can confirm that downgrading to version 4.x works. Did you solve your problem? I am a bit stuck and trying to understand what is happening in version 5.x so that it does not break the build command. |
Are people experiencing this issue using webpack 5? I wonder if this is a common issue with webpack 5; there's something related logged against ts-loader: TypeStrong/ts-loader#1204 |
I dived into changelogs to see what has happened between 4.x and 5.x and I found out, at least it started working in my case.
What is the most interesting I also checked version 6 alpha and they say that the To summarize: For 4.x:
For 5.x:
For 6.x:
|
I'm closing this as it's no longer an issue with the 6.0.0 version :) |
Just adding this in case anyone comes across this like I did. ForkTsCheckerWebpackPlugin won't work nicely with an output with speed-measure-webpack-plugin when using webpack |
Yeah, I just set
|
Current behavior
So, I've tried to use the fork-ts-checker-webpack-plugin in my project, but it doesn't throw any error even I put them for sure.
Expected behavior
Should throw errors if they are present in .ts|.tsx files processed by babel.
Steps to reproduce the issue
Example of the error to reproduce:
![error_image]: (https://i.ibb.co/r5HKHsv/Screen-Shot-2019-07-19-at-10-52-38-AM.png)
Everything is good on output anyway:
![output_image]: (https://i.ibb.co/94c2rFY/Screen-Shot-2019-07-19-at-10-54-18-AM.png)
Environment
The text was updated successfully, but these errors were encountered: