Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting a PR to update profiles always ends in a failure #11367

Closed
2 tasks
64bittuning opened this issue Jan 28, 2022 · 3 comments
Closed
2 tasks

Submitting a PR to update profiles always ends in a failure #11367

64bittuning opened this issue Jan 28, 2022 · 3 comments
Labels
Type: Bug The code does not produce the intended behavior.

Comments

@64bittuning
Copy link
Contributor

64bittuning commented Jan 28, 2022

Application Version

4.13.1

Platform

Windows 10

Printer

Tronxy

Reproduction steps

I have been working on an update for the Tronxy profiles currently in Cura. Upon opening the PR, submitting all of the changed files, and waiting for the build to finish, the PR errors out with a "failure" in test mode 14/15. I have stripped my PR down to uploading a single file which has had only a few lines removed (part of the original update) yet this simple and small change continues to throw an error with a python script checker?

I dont see how all of the plugins and checking those, has anything to do with a printer profile update, but thats why I'm submitting the bug.

I believe this may be related to #11196
Can this be confirmed so I can upload the rest of the file package without driving myself crazy?!?

Actual results

14/15 Test #1: code-style .......................***Failed 21.45 sec

Expected results

14/15 Test #1: code-style ....................... Passed

Checklist of files to include

  • Log file
  • Project file

Additional information & file uploads

see #11366 and (closed) #11362

@64bittuning 64bittuning added the Type: Bug The code does not produce the intended behavior. label Jan 28, 2022
@nallath
Copy link
Member

nallath commented Feb 1, 2022

Yeah, we're working on upgrading some stuff for Cura 5.0 (including an upgrade to Qt 6.2 and python 3.10). But that caused some issues with our build and CI systems. We're working on fixing this!

You can always run the tests locally as well to check if it does succeed there.

@64bittuning
Copy link
Contributor Author

Unfortunately I haven't got a single clue how to initiate the test string locally, otherwise I absolutely would do that. If there is a page I can refer to or a list of instructions you can give, that would be immensely helpful.

@nallath
Copy link
Member

nallath commented Feb 1, 2022

We fixed the issues. So if you base it on the current master, it should work again.

as for the tests, you can run the tests with:

cmake . 
make test

@nallath nallath closed this as completed Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug The code does not produce the intended behavior.
Projects
None yet
Development

No branches or pull requests

2 participants