enhance(logger): avoid extra work for isDebug if DEBUG is not def…

…ined
ardatan · Jul 17, 2023 · f11e9b3 · f11e9b3
1 parent 0160a0e
commit f11e9b3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/.changeset/heavy-baboons-admire.md b/.changeset/heavy-baboons-admire.md
@@ -0,0 +1,5 @@
+---
+'@graphql-mesh/utils': patch
+---
+
+Avoid extra work for `isDebug` if `DEBUG` is not defined
diff --git a/packages/utils/src/logger.ts b/packages/utils/src/logger.ts
@@ -61,11 +61,14 @@ export class DefaultLogger implements Logger {
   }
 
   private get isDebug() {
-    return (
-      process.env.DEBUG === '1' ||
-      (globalThis as any).DEBUG === '1' ||
-      this.name.includes(process.env.DEBUG || (globalThis as any).DEBUG)
-    );
+    if (process.env.DEBUG) {
+      return (
+        process.env.DEBUG === '1' ||
+        (globalThis as any).DEBUG === '1' ||
+        this.name.includes(process.env.DEBUG || (globalThis as any).DEBUG)
+      );
+    }
+    return false;
   }
 
   private get prefix() {