Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json_StringIsLargeNumber returns true when the string is not a valid number #273

Closed
ibrido90 opened this issue Jan 16, 2017 · 1 comment
Closed

json_StringIsLargeNumber returns true when the string is not a valid number #273

ibrido90 opened this issue Jan 16, 2017 · 1 comment

Comments

@ibrido90
Copy link

The function json_StringIsLargeNumber checks only if the string contains '0', 'E', 'e' or '.' characters to say if it's a number or not.
So the string code like this one 012345678901234567890 is recognized as a valid Json number which in reality is not.

We'd like to submit a pull request that patches this issue.
@ibrido90 ibrido90 mentioned this issue Jan 16, 2017
Open
@timhall timhall mentioned this issue Aug 11, 2017
Open
@timhall
Copy link
Member

timhall commented Aug 11, 2017

(moved to VBA-JSON)

@timhall timhall closed this as completed Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timhall @ibrido90