Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MacOS image ci to MacOS-15 #510

Closed

Conversation

mcbarton
Copy link
Contributor

@mcbarton mcbarton commented Feb 2, 2025

This PR adds to the ci jobs which cover MacOS 15. This allows the ci to cover the 2 most recent versions of MacOS.

Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not keep supporting 14?

@mcbarton mcbarton changed the title Update MacOS Github runners in ci to MacOS 15 Added MacOS 15 ci jobs. Feb 2, 2025
@mcbarton
Copy link
Contributor Author

mcbarton commented Feb 2, 2025

Why not keep supporting 14?

Updated the PR to keep MacOS 14, and add MacOS 15 jobs alongside them, so that ci has support for both versions.

@mcbarton mcbarton changed the title Added MacOS 15 ci jobs. Adds MacOS 15 ci jobs. Feb 2, 2025
WASI_SDK_CI_SKIP_SYSROOT: 1
WASI_SDK_CI_TOOLCHAIN_LLVM_CMAKE_ARGS: >-
-DCMAKE_OSX_DEPLOYMENT_TARGET=10.12
-DCMAKE_OSX_ARCHITECTURES=x86_64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed though? I would hope maybe we could just test on one OS version and rely on CMAKE_OSX_DEPLOYMENT_TARGET=10.12 to ensure the result will run widely?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My experience with MacOS is that you can't take anything for granted (Although not specific to this repo, I have worked on ci in the past which worked for MacOS 14 but not MacOS 15). If the plan is to keep just one then I would keep the MacOS 15 runners, since I've found them just as reliable as the MacOS 14 ones while finding them faster.

@mcbarton mcbarton changed the title Adds MacOS 15 ci jobs. Update MacOS image ci to MacOS-15 Feb 3, 2025
@mcbarton mcbarton force-pushed the Update-macos-runner-to-Macos-15 branch from 34160f4 to dd05dcc Compare February 3, 2025 13:03
@alexcrichton
Copy link
Collaborator

Personally I think it's reasonable to update. GitHub Actions images will continue to update over time and additionally phase out older images, so AFAIK it's inevitable that updates are needed. When the updates happen shouldn't impact binary releases too much due to -DCMAKE_OSX_DEPLOYMENT_TARGET=...

To me there's a dual risk either way of if we don't test the latest image then there's a risk it doesn't work. Similarly if we stop testing the old image there's a risk it stops working. Given the CI resources for this repository though I'd say we should only test one and the risks involved here are small enough that it probably doesn't matter which is tested.

One final note is that by changing the names of the jobs it'll require reconfiguring this repository to expect a different job name with "required" checks. If possible can the job names stay the same to avoid needing to reconfigure?

@mcbarton mcbarton force-pushed the Update-macos-runner-to-Macos-15 branch from 7467cdf to 7825b45 Compare February 3, 2025 19:22
@mcbarton
Copy link
Contributor Author

mcbarton commented Feb 3, 2025

Closing as it was chosen to keep older image in order to keep compatibility with older operating systems.

@mcbarton mcbarton closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants