Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevHub] Wrong default mentioned for wp_list_users (exclude_admin) #1849

Open
vHeemstra opened this issue Feb 25, 2025 · 6 comments
Open

[DevHub] Wrong default mentioned for wp_list_users (exclude_admin) #1849

vHeemstra opened this issue Feb 25, 2025 · 6 comments
Labels
[Status] Review Issue in review

Comments

@vHeemstra
Copy link

Issue Description

In the Dev docs on wp_list_users, the default value of exclude_admin is wrong. It says false, but it should be true according to the source code.

URL of the Page with the Issue

https://developer.wordpress.org/reference/functions/wp_list_users/

Section of Page with the issue

Parameters

Why is this a problem?

Wrong default value mentioned.

Suggested Fix

Change false to true in the docs/comment in the source code.

@vHeemstra vHeemstra added the [Status] To do Issue marked as Todo label Feb 25, 2025
Copy link

Heads up @WordPress/docs-issues-coordinators, we have a new issue open. Time to use 'em labels.

@karthick-murugan karthick-murugan self-assigned this Feb 25, 2025
@github-actions github-actions bot added [Status] In progress Issue is in progress and removed [Status] To do Issue marked as Todo labels Feb 25, 2025
@karthick-murugan
Copy link
Collaborator

Please update the following change mentioned in the screenshot.

Image

@karthick-murugan karthick-murugan added [Status] Review Issue in review and removed [Status] In progress Issue is in progress labels Feb 25, 2025
Copy link

Heads up @docs-reviewers - the "[Status] Review" label was applied to this issue.

@vHeemstra
Copy link
Author

vHeemstra commented Feb 25, 2025

Please update the following change mentioned in the screenshot.

Image

🤷‍♂️ This does not add anything to the issue report.

Also, self-assigning the issue and then asking someone to fix it is not what self-assigning means. It means YOU will fix it.

So @karthick-murugan , please keep the contributing guidelines and code of conduct in mind, and either fix the mentioned issue or unassign yourself from it so it can be picked up by someone else.

@karthick-murugan
Copy link
Collaborator

@vHeemstra – Apologies for the misunderstanding. I have now unassigned myself. Thanks for your clarification.

@vHeemstra
Copy link
Author

I can't figure out how to send in a PR with the needed change. But for anyone how knows and can change it, it's this comment line that needs changing: https://core.trac.wordpress.org/browser/trunk/src/wp-includes/user.php#L867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Review Issue in review
Projects
None yet
Development

No branches or pull requests

2 participants