From d7dcf02ad54e91f665f6e7a8a87e8bf4ce605ee7 Mon Sep 17 00:00:00 2001 From: Marco Ciampini Date: Thu, 15 Jun 2023 22:06:44 +0200 Subject: [PATCH] Cleanup code --- .../components/block-settings-menu/block-settings-dropdown.js | 1 + .../src/components/convert-to-group-buttons/index.js | 1 - packages/block-library/src/template-part/edit/index.js | 1 - .../block-settings-menu/plugin-block-settings-menu-item.js | 1 - 4 files changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/block-editor/src/components/block-settings-menu/block-settings-dropdown.js b/packages/block-editor/src/components/block-settings-menu/block-settings-dropdown.js index ad7ba4239f673d..bd24f27b4f3848 100644 --- a/packages/block-editor/src/components/block-settings-menu/block-settings-dropdown.js +++ b/packages/block-editor/src/components/block-settings-menu/block-settings-dropdown.js @@ -375,6 +375,7 @@ export function BlockSettingsDropdown( { onKeyDown={ ( event ) => { if ( event.defaultPrevented ) return; + // TODO: can use `onEscapeKeyDown` prop instead? if ( event.key === 'Escape' ) { setIsDropdownOpen( false ); event.preventDefault(); diff --git a/packages/block-editor/src/components/convert-to-group-buttons/index.js b/packages/block-editor/src/components/convert-to-group-buttons/index.js index eef4d99fcc1f69..6d27bee479a18b 100644 --- a/packages/block-editor/src/components/convert-to-group-buttons/index.js +++ b/packages/block-editor/src/components/convert-to-group-buttons/index.js @@ -70,7 +70,6 @@ function ConvertToGroupButton( { { onConvertFromGroup(); - // onClose(); } } > { _x( diff --git a/packages/block-library/src/template-part/edit/index.js b/packages/block-library/src/template-part/edit/index.js index b2a4ed546d0ed4..dd27a423f5dcf6 100644 --- a/packages/block-library/src/template-part/edit/index.js +++ b/packages/block-library/src/template-part/edit/index.js @@ -163,7 +163,6 @@ export default function TemplatePartEdit( { ) } { canReplace && ( - { /* TODO: check if this used in other legacy dropdown menus */ } { setIsTemplatePartSelectionOpen( true ); diff --git a/packages/edit-post/src/components/block-settings-menu/plugin-block-settings-menu-item.js b/packages/edit-post/src/components/block-settings-menu/plugin-block-settings-menu-item.js index edfcf34ae51988..074070dfd7579a 100644 --- a/packages/edit-post/src/components/block-settings-menu/plugin-block-settings-menu-item.js +++ b/packages/edit-post/src/components/block-settings-menu/plugin-block-settings-menu-item.js @@ -101,7 +101,6 @@ const PluginBlockSettingsMenuItem = ( { return null; } return ( - /* TODO: check if this used in other legacy dropdown menus */ }