Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block mover not actionable when the theme content is left aligned #12290

Closed
afercia opened this issue Nov 25, 2018 · 1 comment
Closed

Block mover not actionable when the theme content is left aligned #12290

afercia opened this issue Nov 25, 2018 · 1 comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes.

Comments

@afercia
Copy link
Contributor

afercia commented Nov 25, 2018

Noticed in Twenty Nineteen, see WordPress/twentynineteen#665 and WordPress/twentynineteen#614

The "block mover" position in Gutenberg makes the assumption the post content is centered.

Normally, the block mover is positioned vertically on the left of the block. Instead, when a block is set to "wide" or "full" alignment, the block mover is positioned horizontally "inline" with the block toolbar.

With a "full" alignment, there is space on the left for the block mover unless the theme changes the toolbar position: Twenty Nineteen does change the toolbar position and this is tracked in WordPress/twentynineteen#665. Themes should just not change the toolbar position: problem solved.

However, the real problem in Gutenberg is with the "wide" alignment. When the post content is left aligned, there's really no space to display the block mover:

screenshot 2018-11-25 at 13 36 49

I'd tend to think this should be better handled in Gutenberg itself, as mentioned at some point in WordPress/twentynineteen#614

@afercia afercia added [Type] Bug An existing feature does not function as intended [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes. labels Nov 25, 2018
@youknowriad
Copy link
Contributor

I think that issue is fixed. I can access the movers properly in wide aligned images in TwentyNineteen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes.
Projects
None yet
Development

No branches or pull requests

2 participants