Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo after automatic change causes block to loose focus #17912

Closed
mrfatguy opened this issue Oct 11, 2019 · 3 comments
Closed

Undo after automatic change causes block to loose focus #17912

mrfatguy opened this issue Oct 11, 2019 · 3 comments
Labels
[Feature] History History, undo, redo, revisions, autosave.

Comments

@mrfatguy
Copy link

This is somewhat extension to #12002. If this is about to be added to #12327 then IMHO must be added with good description as this seems to be a quite different thing than all the scenarios given in #12327.

Describe the bug
When user undoes an automatic change (i.e. changing block type into list after writing 1.) within the same block, this block itself looses focus. This does not happen during regular writing, i.e. after non-automated change.

To reproduce
Steps to reproduce the behavior:

  1. Start a new block.
  2. Type 1. and hit Space.
  3. Observe automatic change of block's type from paragraph to numbered list.
  4. hit Ctrl+z or click appropriate button in toolbar to undo this automatic change.
  5. Observe that focus is lost / shifted from active block.

Repeat above steps writing anything that does not trigger an automatic change and observe that you can undo as much operations as you need without loosing focus from current block.

Expected behavior
Undo behavior should be consistent. No undo operation should cause a block to loose focus.

Desktop (please complete the following information):

  • OS: Windows 7
  • Browser: Chrome 77
  • Gutenberg: 6.6.0
@swissspidy swissspidy added the [Feature] History History, undo, redo, revisions, autosave. label Oct 14, 2019
@ellatrix
Copy link
Member

Thanks for the report! We're aware of this issue. It should be fixed by #17824. Would you be able to test it?

@mrfatguy
Copy link
Author

Of course. Just let me know, if I should test unstable nightly or wait for the stable production version?

BTW: Loosing focus on undo is a small thing. Great that you've fixed it, but that could wait. The #16172 is by far more important, because it is open 4+ months and drives million of people crazy.

@mrfatguy
Copy link
Author

Closing as #17824 is closed and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] History History, undo, redo, revisions, autosave.
Projects
None yet
Development

No branches or pull requests

3 participants