Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect escaping function used on Social Link block. #17933

Closed
ryanwelcher opened this issue Oct 14, 2019 · 1 comment
Closed

Incorrect escaping function used on Social Link block. #17933

ryanwelcher opened this issue Oct 14, 2019 · 1 comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time

Comments

@ryanwelcher
Copy link
Contributor

Describe the bug
The function that is being used to escape the URL on the Social link block is incorrect. It is using esc_attr and it should be esc_attr
@ryanwelcher ryanwelcher added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Oct 14, 2019
@ryanwelcher ryanwelcher mentioned this issue Oct 14, 2019
Merged
5 tasks
@brentswisher
Copy link
Contributor

This was fixed in #17932 which has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryanwelcher @brentswisher