Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block navigation no longer highlights currently selected block #24520

Closed
njwgh opened this issue Aug 12, 2020 · 7 comments · Fixed by #24609
Closed

block navigation no longer highlights currently selected block #24520

njwgh opened this issue Aug 12, 2020 · 7 comments · Fixed by #24609
Assignees
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Status] In Progress Tracking issues with work in progress [Type] Regression Related to a regression in the latest release

Comments

@njwgh
Copy link

njwgh commented Aug 12, 2020

The block navigation is not highlighting the block that the cursor is currently in

To reproduce
Click on a block
Click on the 'Block Navigation'
It has the top block highlighted not the block the cursor is currently in

Expected behavior
It should highlight the block that the cursor is currently in

Editor version (please complete the following information):

  • WordPress version: 5.5
    Default Gutenberg
    Theme: twentytwenty
    NO plugins

Desktop (please complete the following information):

  • OS: windows
  • Browser Chrome
  • Version 84.0.4147.105

Screenshots
block-navigation

@Computerbuddha
Copy link

Same issue here! And hover not active (sub-)items with the mouse does not change the background color. Also the spacing between the items is bigger than before. On smaller screens - e.g. laptop - this is not so optimal.

@annezazu
Copy link
Contributor

@njwgh @Computerbuddha it sounds like you might describing this currently open and heavily discussed issue: #23892 Can you review and, if this matches what you're describing, close this issue out in favor of continuing the discussion there? Thank you!

@njwgh
Copy link
Author

njwgh commented Aug 15, 2020

@annezazu This is NOT the same issue as #23892
This issue is about the drop-down navigation block, NOT about the highlight of the currently selected block
image

@ellatrix ellatrix added [Type] Regression Related to a regression in the latest release [Feature] Navigation Component A navigational waterfall component for hierarchy of items. labels Aug 17, 2020
@ellatrix
Copy link
Member

Seems like this regressed. @talldan Do you know anything about this?

@Computerbuddha
Copy link

See here the differences between WP 5.4 and 5.5:

grafik

grafik

@talldan
Copy link
Contributor

talldan commented Aug 18, 2020

Yes, this does seem like a regression. Looks like it was accidentally removed here in changes that were only supposed to land in the navigation screen:
https://github.com/WordPress/gutenberg/pull/22996/files#diff-3d2c7e20b234263753f1a83b39a15724L59-L66

@talldan talldan added [Feature] List View Menu item in the top toolbar to select blocks from a list of links. and removed [Feature] Navigation Component A navigational waterfall component for hierarchy of items. labels Aug 18, 2020
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 18, 2020
@talldan
Copy link
Contributor

talldan commented Aug 18, 2020

Fix was pretty straightforward - #24609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Status] In Progress Tracking issues with work in progress [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants