Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating an image next to paragraph not intuitive #2549

Closed
emailprotwk opened this issue Aug 27, 2017 · 5 comments
Closed

Floating an image next to paragraph not intuitive #2549

emailprotwk opened this issue Aug 27, 2017 · 5 comments
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time

Comments

@emailprotwk
Copy link

My testing goal was to add an image and float it next to a paragraph. I added a paragraph first, but found there is no tool to add an image to the left or right of the image.

I was told to add the image first, float it. Then to add the paragraph, which automatically floated the paragraph.

Also, I don't understand the box around the image. Is this margin or padding? How do we edit it?

@ammist
Copy link

ammist commented Aug 27, 2017

To add to this:

I tried the following:

  1. Add an image. This caused the image to fill up the space. I added a caption below.
  2. I added a paragraph below the image.
  3. I wanted to make the image smaller than full-width, so I resized the image inside the image block.
  4. The caption continued to take up the full amount of space, the grey border remained around the image.
  5. I click "float left" on the image. The block did not float. See screenshot.

2017-08-27_14-01-50

Skipping step 3 allows the image to flow next to the paragraph.

@ellatrix
Copy link
Member

Looks like this is a styling issue. The caption should not be wider than the image.

@ellatrix ellatrix added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Aug 28, 2017
@ammist
Copy link

ammist commented Aug 28, 2017

@iseulde Would you fix the styling by adding a max-width inline style to the "figure" container? If you take a look at the linked ticket (#2555) I've pasted the HTML code that's generated by the caption both in the Gutenberg editor and in the HTML for the front-end. After looking at the code I think I could do this (good first task!) but I'm not sure what the conventions are supposed to be for setting hard-coded widths (for things other than images)

@ammist
Copy link

ammist commented Sep 7, 2017

It looks like this might be fixed in #2682. Will test again w/ @emailprotwk when that gets wrapped into a release.

@mtias
Copy link
Member

mtias commented Nov 20, 2017

Closing as fixed.

image

@mtias mtias closed this as completed Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time
Projects
None yet
Development

No branches or pull requests

5 participants