Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The editor styles background is not applied properly. #31651

Closed
youknowriad opened this issue May 10, 2021 · 6 comments
Closed

The editor styles background is not applied properly. #31651

youknowriad opened this issue May 10, 2021 · 6 comments
Assignees
@ellatrix
Labels
Browser Issues Issues or PRs that are related to browser specific problems General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended

Comments

@youknowriad
Copy link
Contributor

When using a theme with a background like 2020, and on long posts, you'll notice that the background of the editor stops at 100vh (See screenshot)

Capture d’écran 2021-05-10 à 10 39 04 AM

Could this be related to the recent changes to the visual editor to iframe the template editor or maybe add the animations. cc @jasmussen @ellatrix
@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended General Interface Parts of the UI which don't fall neatly under other labels. labels May 10, 2021
@jasmussen
Copy link
Contributor

I'm not sure how to reproduce. I'm trying latest TwentyTwenty and not seeing the same:

Screenshot 2021-05-10 at 13 33 00

@youknowriad
Copy link
Contributor Author

Ok, this looks to be Safari specific.

@youknowriad youknowriad added the Browser Issues Issues or PRs that are related to browser specific problems label May 11, 2021
@ellatrix ellatrix self-assigned this May 14, 2021
@ellatrix
Copy link
Member

Hm, I can't reproduce it in Safari either

@youknowriad
Copy link
Contributor Author

Yep, this seems fixed now. (I think with your latest PR that touched VisualEditor)

I noticed that we have double scrollbars which is not great in viewport previews and template mode.

@jasmussen
Copy link
Contributor

Do you mean this double scrollbar? #30055

Or another?

@youknowriad
Copy link
Contributor Author

Capture d’écran 2021-05-17 à 12 24 25 PM

Maybe it's the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ellatrix ellatrix

Labels
Browser Issues Issues or PRs that are related to browser specific problems General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@youknowriad @jasmussen @ellatrix