Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyMCE script loading #3405

Closed
Afraithe opened this issue Nov 9, 2017 · 5 comments
Closed

TinyMCE script loading #3405

Afraithe opened this issue Nov 9, 2017 · 5 comments
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Status] Needs More Info Follow-up required in order to be actionable. [Type] Build Tooling Issues or PRs related to build tooling

Comments

@Afraithe
Copy link

Afraithe commented Nov 9, 2017

Issue Overview

Currently, TinyMCE is loaded through a custom url used mostly for an easy way of getting nightlies at the start of the project. This should move to use NPM to pull down TinyMCE.

There also isn't really any reason why WP couldn't use the same TinyMCE for Gutenberg as for the "old" editor page (if the updates remain in sync). Ending up with the script included twice with different versions would be bad practice.

These are the lines affected in Gutenberg.
https://github.com/WordPress/gutenberg/blob/master/lib/client-assets.php#L244

Current Behavior

Script is loaded vi a custom url.

Possible Solution

Should pull down TinyMCE via NPM or similar.

@ephox-mogran
Copy link
Contributor

@mtias are you aware of this issue?

@mtias mtias added [Type] Build Tooling Issues or PRs related to build tooling Framework Issues related to broader framework topics, especially as it relates to javascript labels Nov 20, 2017
@mtias
Copy link
Member

mtias commented Nov 20, 2017

Marking as part of build tooling.

@youknowriad
Copy link
Contributor

Using the same version for TinyMCE for Gutenberg and the classic block would solve several issues. I tried this PR to align the versions #3840 but it doesn't solve the duplication issue.

Can we update the "Core" version in Gutenberg while in the plugin phase? maybe not, at least I'm not sure how to do so.

@danielbachhuber
Copy link
Member

@mtias @youknowriad What, if anything, still needs to happen for this issue?

@danielbachhuber danielbachhuber added the [Status] Needs More Info Follow-up required in order to be actionable. label May 25, 2018
@youknowriad
Copy link
Contributor

I think this is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Status] Needs More Info Follow-up required in order to be actionable. [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

No branches or pull requests

5 participants