Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor all menu selection data fetch and permission checks into compomnent #38523

Open
getdave opened this issue Feb 4, 2022 · 0 comments
Open
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Type] Code Quality Issues or PRs that relate to code quality

Comments

@getdave
Copy link
Contributor

getdave commented Feb 4, 2022

Follow up to #38179 (comment)_. We need to pull all the:

  • data fetching
  • permissions checking

...so that it is within the Select menus component itself. This means we don't have to keep compiling the arguments each time we need it.

This could also be within a hook in order that we can retain a separation of concerns between component and logic.

Related: #37190


Adam and I discussed off Github about tackling this incrementally. I'll now follow up to consolidate all the data fetching and permissions checking into one single component which we can reuse everywhere.

Originally posted by @getdave in #38179 (comment)

@getdave getdave added [Block] Navigation Affects the Navigation Block [Type] Code Quality Issues or PRs that relate to code quality labels Feb 4, 2022
@getdave getdave self-assigned this Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

No branches or pull requests

1 participant