Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exported JSON loses 'appearanceTools' abstraction #39464

Closed
pbking opened this issue Mar 15, 2022 · 1 comment · Fixed by #39840
Closed

Exported JSON loses 'appearanceTools' abstraction #39464

pbking opened this issue Mar 15, 2022 · 1 comment · Fixed by #39840
Assignees
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Package] Edit Site /packages/edit-site [Type] Bug An existing feature does not function as intended

Comments

@pbking
Copy link
Contributor

pbking commented Mar 15, 2022

Description

When exporting the theme from the FSE the included theme.json is missing the appearanceTools attribute present in the theme's theme.json file and instead the attributes that abstracts are added instead.

Missing attribute present in original theme.json:
settings.appearanceTools

Among added attributes:
settings.color.custom
settings.color.customGradient
settings.color.link
settings.spacing.padding
settings.spacing.blockGap
settings.spacing.margin

I expect this is because the "appearanceTools" attribute is flipping all of those values "true" without the need to provide them. However it may be desirable to keep the original attribute in exported configuration so that if any additional attributes are enabled due to that value they are also included in the theme.

Step-by-step reproduction instructions

Activate a theme that defines settings.appearanceTools: true in the theme.json file.
Export that theme from the FSE using the hamburgerMenu>TOOLS>Export tool.
Compare the theme.json exported to the theme.json provided by the theme. Note that appearanceTools setting is absent while the values it represents are present.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@bph bph added [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Bug An existing feature does not function as intended labels Mar 15, 2022
@skorasaurus skorasaurus added the [Package] Edit Site /packages/edit-site label Mar 15, 2022
@scruffian
Copy link
Contributor

Fixed by #39590

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 29, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Package] Edit Site /packages/edit-site [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants