Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace template part flow: Preview showing "block cannot be rendered inside itself" #44210

Closed
annezazu opened this issue Sep 15, 2022 · 0 comments · Fixed by #44256
Closed

Replace template part flow: Preview showing "block cannot be rendered inside itself" #44210

annezazu opened this issue Sep 15, 2022 · 0 comments · Fixed by #44256
Assignees
@talldan
Labels
[Block] Template Part Affects the Template Parts Block [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

Description

When trying to use the replace template part flow, I noticed that the preview items for various TT2 template parts show an error but seem to work upon insertion. I'm not sure if this is GB or TT2 related but wanted to note it here.

Step-by-step reproduction instructions

  1. Open the site editor using TT2.
  2. Select a header or footer.
  3. Click the three dot menu > hit replace.
  4. Notice that some of the template parts/patterns show an error.

Screenshots, screen recording, code snippet

Screen Shot 2022-09-15 at 2 58 43 PM

Environment info

  • WP 6.0.2
  • GB 14.1
  • TT2

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Block] Template Part Affects the Template Parts Block labels Sep 15, 2022
@talldan talldan mentioned this issue Sep 19, 2022
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 19, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@talldan talldan

Labels
[Block] Template Part Affects the Template Parts Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid showing the recursion warning in previews when replacing template parts WordPress/gutenberg
3 participants
@talldan @annezazu @priethor