Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More granular options for pushing local styles to global styles #45624

Open
jameskoster opened this issue Nov 9, 2022 · 0 comments
Open

More granular options for pushing local styles to global styles #45624

jameskoster opened this issue Nov 9, 2022 · 0 comments
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

A follow-up to #44361.

After we make it possible to push all local block styles to global styles, it could be good to explore how we can add a little more granularity to the feature.

There will be situations in which you heavily customise a block locally and want to push some of those changes upstream, but keep some local.

Per-panel pushing would afford more granularity, and per-control pushing would take things to the extreme. A rough mockup meant only to communicate the idea:

Screenshot 2022-11-09 at 11 54 45

In order to implement this, we'll need to design a pattern for the UI which indicates when the styles within a local panel have departed from global styles. A dot marker was suggested in 44361 but ruled out due to "unread-dot fatigue". Let's explore alternatives, and discuss whether we need both per-panel and per-control pushing.

@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. Needs Design Needs design efforts. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

1 participant