-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow link suggestions to be configurable #4598
Comments
While working on #4649, I thought of an alternate implementation:
|
@iseulde @nylen I think ^ would be a reasonable solution for https://core.trac.wordpress.org/ticket/39965 too. |
also @kadamwhite ^ |
This makes sense to me. Making the endpoint's query filterable could turn up whatever is relevant to that site. I would also recommend the result contain an ID or GUID attribute in addition to the URL and title. However, I'm a little more skeptical that this will be a sufficient solution for #39965; worth discussing, for sure, but our experience is that developers are always frustrated having to make two requests, and providing a slimmed-down search endpoint will still mean that we need to individually query for the full resources (discussions from the 4.8 cycle suggest returning multiple resources with different structures in one request could be an issue for API clients written in certain languages). |
How much data do you think would need to be included in the response in order to be sufficient? |
@danielbachhuber I think that question's out of the scope of this GitHub issue; let's continue it in trac perhaps? But briefly, I don't know that I can say. Custom post types may not even use or have post content or a title, and meta may be needed for some rather than others, so it's unpredictable. There doesn't seem to be an easy one-size-fits-all solution. |
This will be addressed with #2084 |
Issue Overview
The url-input component uses
wp.api.collections.Posts
to suggest posts you might want to link to, as you type a link.This doesn't work for all WordPress installs (on some configurations, the
Posts
collection isn't usable), and some networks want to suggest posts from all of their sites.This issue is to discuss possible solutions.
The text was updated successfully, but these errors were encountered: