Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Block inserter challenges #46425

Closed
scruffian opened this issue Dec 9, 2022 · 2 comments
Closed

Navigation: Block inserter challenges #46425

scruffian opened this issue Dec 9, 2022 · 2 comments
Labels
[Block] Navigation Affects the Navigation Block Needs Design Feedback Needs general design feedback. [Type] Question Questions about the design or development of the editor.

Comments

@scruffian
Copy link
Contributor

By default the navigation block uses a Link UI to insert blocks:
Screenshot 2022-12-09 at 10 40 52

This is because in the majority of cases users will want to add links to their navigation, rather than other blocks. We also provide several transforms to popular blocks: "search", "social icons" and "site logo". If a user adds one of these blocks then on subsequent interactions the block inserter changes to look like this:

Screenshot 2022-12-09 at 10 47 47

Now that the Page List block can be configured to display only the child pages of a selected parent, we anticipate that users will also want to add this block to their navigation, which is currently not possible.

In #42257 @SaxonF suggests a new interface for adding blocks to a navigation:
Screenshot 2022-12-09 at 10 46 20

This raises several questions:

  1. Should this new block inserter be the new default for all blocks added to the navigation block?
    1a. If no then should we make it easier to add a Page List block using the initial inserter (the Link UI)?
    1b. If yes then does this mean we no longer expect the majority use case to simply be adding custom links?
  2. Does the search field on this inserter search for posts and pages or blocks, or both?
@scruffian scruffian added the [Block] Navigation Affects the Navigation Block label Dec 9, 2022
@draganescu draganescu added [Type] Question Questions about the design or development of the editor. Needs Design Feedback Needs general design feedback. labels Dec 12, 2022
@getdave
Copy link
Contributor

getdave commented Jan 9, 2023

@scruffian I think this has all been addressed right?

@scruffian
Copy link
Contributor Author

We have a way forward here. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Needs Design Feedback Needs general design feedback. [Type] Question Questions about the design or development of the editor.
Projects
None yet
Development

No branches or pull requests

3 participants