Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Panel: popover opens in incorrect position #49349

Closed
ciampo opened this issue Mar 24, 2023 · 3 comments
Closed

Color Panel: popover opens in incorrect position #49349

ciampo opened this issue Mar 24, 2023 · 3 comments
Labels
[Feature] Colors Color management [Type] Bug An existing feature does not function as intended

Comments

@ciampo
Copy link
Contributor

ciampo commented Mar 24, 2023

As reported in #48893 by @jasmussen, @andrewserong , @aaronrobertshaw and @youknowriad , the popover can sometimes open in the wrong position

227121200-ae996efc-77ff-4ae6-8645-d62d51e65a7f.mp4
227105513-abbbf1f1-9649-4aab-865b-91631110c597.mp4
@ciampo
Copy link
Contributor Author

ciampo commented Mar 24, 2023

As reported in #48893 (comment), it seems that it happens only when the popover contains a tabbed interface (e.g "Solid" and "Gradient" tabs for the background color, or "Default" and "Hover" tabs for the "Link" color). Maybe this could help to narrow down the issue.

For more context, the Popover in question is part of the Dropdown component. The Dropdown component should set the anchor for the Popover component (the anchor should be the individual item group).

@youknowriad
Copy link
Contributor

If it happens only for the tabbed interface, I'm guessing that maybe the "width" of the popover is not right (probably 0) at the time the position gets computed causing the wrong position. So some kind of race condition where we don't update the position based on the right width properly.

@ciampo
Copy link
Contributor Author

ciampo commented Apr 4, 2023

#49368 seems to have fixed this issue, closing now

@ciampo ciampo closed this as completed Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Colors Color management [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants