Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.2 alignwide and alignfull is not showing #49549

Closed
derridHeidegger opened this issue Apr 3, 2023 · 12 comments
Closed

6.2 alignwide and alignfull is not showing #49549

derridHeidegger opened this issue Apr 3, 2023 · 12 comments
Labels
Needs Testing Needs further testing to be confirmed.

Comments

@derridHeidegger
Copy link

Description

hi
i am using my custom theme. in 6.1 the toolbar include the alignwide and alignfull buttons. and obviously i have the .alignwide and .alignfull classes. (are the names of the classes styed the same?)
after updating to 6.2 the toolbar doesn't have the alignwide and alignfull buttons.

my theme.json in the settings i have:
"appearanceTools": true, "useRootPaddingAwareAlignments": true, "layout": { "contentSize": "860px", "wideSize": "1100px" },

in my function.php file i have:
add_theme_support( 'align-wide' );

6 1group-same-custom-theme
6 2group

i hope the images pass, so you can see the issue.

another issue is that in 6.2 style variations previews on RTL site are covering the style variation buttons, so it is really hard to use:
forstylevariations

those are really big issues. let me know what am i missing and how to fix the issues

Step-by-step reproduction instructions

  1. add a group block, or image block, or cover (i have tested those)
  2. look at the toolbar
  3. see there are no alighwide or alighfull buttons

Screenshots, screen recording, code snippet

forstylevariations
6 1group-same-custom-theme
6 2group

Environment info

WordPress 6.2
edge and chrome browsers
windows 11 desktop

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@mrfoxtalbot
Copy link

mrfoxtalbot commented Apr 3, 2023

Thank you for reporting this @derridHeidegger. Regarding the second issue you mentioned:

in 6.2 style variations previews on RTL site are covering the style variation buttons, so it is really hard to use:

I cannot reproduce this but I am not sure I understand. The color picker on my test site seems to be floating to the side of the options. Here's what I see:

Screen.Capture.on.2023-04-03.at.12-06-28.mp4

Or were you perhaps referring to the variation preview when using the transform block feature, as seen in this other screen recording?

Screen.Capture.on.2023-04-03.at.12-12-47.mp4

If this is not what you were referring to, could you please share a screen recording to clarify? Thank you!

@derridHeidegger
Copy link
Author

derridHeidegger commented Apr 3, 2023

hi
thank you for answering. i have recorded both issues. the style variation and the alignwide and full. in this case on the group block:

Untitled.video.-.Made.with.Clipchamp.2.mp4

i hope the video will be shown... by the way, the style variation is on hover not on click

@t-hamano
Copy link
Contributor

t-hamano commented Apr 3, 2023

@derridHeidegger

Thanks for the report. I think that one issue should address one problem. I have created a new issue for the block styles preview as #49554.

In this issue, let's discuss the issue of alignwide and alignfull.

@t-hamano
Copy link
Contributor

t-hamano commented Apr 3, 2023

Thanks for the report.

As for the alignwide/alignfull issue, I could not reproduce it in my environment. Could you please check the following?

group

@Andrew-Starr
Copy link

I am seeing a very similar issue and I'm not sure if it is related to this or whether it would be a separate issue.

I'll try to explain it as best I can.

When I have a static homepage set at Settings > Reading, and the content of the homepage contains wide or full-width content, the wide and full-width blocks are displayed as the default width (650px in TT3) in the site editor only. Page/post editor is unaffected.

Wide and full-width are displaying correctly in other template parts, as is the header and footer parts. It is only the page template when a static homepage is defined as the site editor displays the content of the static homepage when initially loading.

If I edit the Post Content block and toggle off the "Inner blocks use content width" and toggle it back on again, then the wide and full-width blocks display correctly.
If I then exit the site editor and then go back into the site editor, the issue is again present until I toggle off then on again the "Inner blocks use content width" option of the Post Content block.

The issue is present with every theme I have tested including TT3, and with Gutenberg plugin both active and inactive.

@spencerfinnell
Copy link

Are you using the official version of WordPress 6.2?

Thank you @t-hamano -- I was caught by this using a nightly build.

@kathrynwp
Copy link

@spencerfinnell Glad the issue is resolved by activating the stable version of 6.2. I'm going to close out this issue.

@Andrew-Starr To keep things organized, could you please either open a new issue or start a thread in the WordPress.org Support forums so someone can troubleshoot with you directly? Thanks very much.

@Andrew-Starr
Copy link

@kathrynwp I was going to open a new issue but thought these two issues may have been related.
The weird thing is the issue suddenly fixed itself without me having to do anything (never seen this before in all my time using WP). If the issue presents again I will open a new issue as it seems the two are not related.

@derridHeidegger
Copy link
Author

hi
sorry i am in the middle of a holiday. this is really bizzare:
the same custom theme with WP 6.1 both alignments and style variations previews worked correctly. now with the OFFICIAL 6.2 the UI for the alignwide and alignfull are disappearing after a few seconds.
i am adding a new video that show both issues.

i have tested with twenty twernty three theme.....and there are no issues there. so i assume it is something with my custom theme? but have no idea why! i have tried playing with my theme.json and the add_theme_support( 'align-wide' ) but nothing change. any idea? anyone else get this issue?

alignUI-disapear.after.several.seconds.-.Made.with.Clipchamp.mp4

@kathrynwp
Copy link

kathrynwp commented Apr 6, 2023

@derridHeidegger I'd suggest posting in the support forums to ask for troubleshooting help! Cheers.

@spencerfinnell
Copy link

I am actually still seeing inconsistency with this... perhaps more similar to @Andrew-Starr is experiencing. wp core update --version=latest --force fixes it for me each time, but I'm not exactly sure why -- or why it keeps getting removed in the first place.

@derridHeidegger
Copy link
Author

ok i found the issue at least for me, so maybe it will help others: on my templates , on the post-content comment i added: {"layout":{"type":"constrained"}}

that fixed the align issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Testing Needs further testing to be confirmed.
Projects
None yet
Development

No branches or pull requests

6 participants