Global Styles - Custom Colors given the same name cannot be applied properly

[cuemarie]

Description

If custom colors are added in the global styles theme settings with the same name (eg Color 1), it becomes impossible to select any color but the last custom color of that name.

Step-by-step reproduction instructions

1. Start in site editor
2. Select global styles
3. Colors>Palettes>Custom Colors, add custom colors
4. Select "Show Details" in the menu for custom colors, and rename all the colors to the same name, such as "Color 1"
5. Return to the editor, and try selecting one of these custom color for any block color setting

Screenshots, screen recording, code snippet

Setup

Result

Environment info

Originally reported here: Automattic/wp-calypso#75197
Replicated in WP version 6.2 with all Gutenberg plugin active and deactivated.
Theme: Twenty Twenty-Three

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[aaronrobertshaw]

I believe this issue might be considered a duplicate of #43197.

The issue was also touched on in a related PR #43096 (comment).

[ramonjd]

I added some thoughts over in: #43197 (comment)

[ramonjd]

I think this PR fixes the issue:

• PaletteEdit: dedupe palette element slugs #65772

but only for duplicate named colors created after that PR.

Is that sufficient to close this issue?

[aaronrobertshaw]

Is that sufficient to close this issue?

In my view, yes.

More than likely, anyone having hit this issue renamed the colors so they could be applied correctly.

[ramonjd]

Fixed by #65772