Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments cannot be enabled from site editor on a page #54019

Open
draganescu opened this issue Aug 29, 2023 · 3 comments · May be fixed by #68384
Open

Comments cannot be enabled from site editor on a page #54019

draganescu opened this issue Aug 29, 2023 · 3 comments · May be fixed by #68384
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Feature] Page Content Focus Ability to toggle between focusing on editing the page and editing the template in the site editor. Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@draganescu
Copy link
Contributor

Description

When creating a page from the site editor, if the template used includes a comments block, then the comments block displays an enable comments button.

But you can't click that button because it's in the template. If you edit the template the comments block lists sample commments and the enable comments button - as it should - disappears.

Back in the page the button is back.

The document inspector does not have the discussion panel like the post editor does, so there is no way to turn comments on.

Step-by-step reproduction instructions

  1. Use TT3 unmodified
  2. Go to site editor
  3. Click pages
  4. Click the plus button in the top right of the sidebar
  5. Give the page a name
  6. Observe the enable comments button shown in the template

Screenshots, screen recording, code snippet

comment-loop.mp4

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@draganescu draganescu added [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Feature] Page Content Focus Ability to toggle between focusing on editing the page and editing the template in the site editor. labels Aug 29, 2023
@annezazu annezazu moved this to Needs Design Feedback in WordPress 6.4 Editor Tasks Aug 30, 2023
@SaxonF
Copy link
Contributor

SaxonF commented Sep 3, 2023

Thanks for highlighting! Definitely a gap we didn't account for. It looks like this issue is a duplicate of #53188 which is part of https://github.com/orgs/WordPress/projects/127?pane=issue&itemId=37188610.

The suggestion is to just bring in the discussion panel which I agree would be a good first step. I imagine the "enable" button should just go away so when editing page you see the "comments are disabled" message and when editing template you see placeholder comments.

@draganescu
Copy link
Contributor Author

I wouldn't close this one. #53188 is about enabling comments from page editing in the site editor, this one is about the behavior of the comments block and of the template editing.

I think too that the enable comments button should go away - it's making the user do an action that - while it seems contextual - is removed from the actual effect it causes.

@nudgeD
Copy link

nudgeD commented Sep 6, 2023

I agree the “Enable comment” button doesn’t seem to serve the right purpose atm. I would suggest hiding it for now in the site editor.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Feature] Page Content Focus Ability to toggle between focusing on editing the page and editing the template in the site editor. Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants