Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid <code> tags in No follow label of Link Control in Rich Text #54179

Closed
getdave opened this issue Sep 5, 2023 · 1 comment
Closed

Avoid <code> tags in No follow label of Link Control in Rich Text #54179

getdave opened this issue Sep 5, 2023 · 1 comment
Assignees
@getdave
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@getdave
Copy link
Contributor

getdave commented Sep 5, 2023 •
edited
Loading

Remove code tag from

gutenberg/packages/format-library/src/link/inline.js

Line 39 in ab5a41c

__( 'Mark as <code>nofollow</code>' ),

This causes a screen reader accessibility issue. No code tags in labels. Not actually sure why this is as it seems to be allowed per the HTML specification but with testing, it is an issue.

Maybe this is a better label?

					__( 'Add no-follow for search engines' ),

Originally posted by @alexstine in #54110 (comment)
@getdave getdave self-assigned this Sep 5, 2023
@getdave getdave added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Sep 5, 2023
@getdave getdave mentioned this issue Sep 5, 2023
Merged
@bangank36 bangank36 mentioned this issue Sep 5, 2023
Merged
@getdave
Copy link
Contributor Author

getdave commented Sep 7, 2023

Closed by #54184

@getdave getdave closed this as completed Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getdave getdave

Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@getdave