Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyMCE fields look for skins in the wrong place #5522

Closed
petertwise opened this issue Mar 9, 2018 · 1 comment
Closed

TinyMCE fields look for skins in the wrong place #5522

petertwise opened this issue Mar 9, 2018 · 1 comment
Labels
[Type] Bug An existing feature does not function as intended

Comments

@petertwise
Copy link

Issue Overview

What's specifically breaking ACF's WYSIWYG editor for me is that Gutenberg is looking for CSS files in /wp-content/plugins/gutenberg/vendor/skins

If I copy /wp-includes/js/tinymce/skins/* to /wp-content/plugins/gutenberg/vendor/skins it fixes the issue.

Can we get Gutenberg to look for those CSS files in the core tinymce skins directory or include the skins in the place where Gutenberg is looking for them?

I realize #3840 is still open for various reasons, but this seems to address the TinyMCE js files and not the CSS styles that are required.

Steps to Reproduce (for bugs)

WordPress 4.9.4
Gutenberg 2.3.0
ACF Pro 5.6.9

  • Add an ACF WYSIWYG field
  • go to the Gutenberg version of the edit or add page screen
  • TinyMCE editor in the meta box breaks due to 404 on /wp-content/plugins/gutenberg/vendor/skins/lightgray/skin.min.css and /plugins/gutenberg/vendor/skins/lightgray/content.min.css

Possible Solutions

A. Get TinyMCE's version that is loaded by Gutenberg to look for those files where they exist already in core: /wp-includes/js/tinymce/skins/
B. Add the CSS files to the Gutenberg vendors directory /plugins/gutenberg/vendor/skins

Screenshots / Video

https://www.dropbox.com/s/55y2tntp935dkt4/Screenshot%202018-03-08%2021.24.44.png?dl=0

Related Issues and/or PRs

#3731
#3840

@jeffpaul jeffpaul added the [Type] Enhancement A suggestion for improvement. label Mar 14, 2018
@karmatosed karmatosed added [Type] Bug An existing feature does not function as intended [Component] TinyMCE and removed [Type] Enhancement A suggestion for improvement. labels Apr 27, 2018
@youknowriad
Copy link
Contributor

closed by #6848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants