Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation block inspector: Move menu name, delete, manage menus to a more appropriate place #60171

Open
afercia opened this issue Mar 25, 2024 · 2 comments
Labels
[Block] Navigation Affects the Navigation Block [Feature] Navigation Menus Any issue relating to Navigation Menus Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Mar 25, 2024

Description

In a way, related to #59706

In the Navigation block inspector, there are 3 tabs:

  • List View: it contains the Menu tree.
  • Settings: it's meant to contain settings of the navigation block.
  • Styles: it contains style settings for the navigation block.

Screenshot 2024-03-25 at 14 41 19

However, the 'Settings' tab contains also some stuff that is specifically related to a menu;

  • Menu name input field.
  • Delete menu button.
  • 'Manage menus' link that points to the classic admin page to edit all menus.

I'm not sure these three items are in the right place.

  • They are not 'settings' in the first place.
  • They are not related to the Navigation block.
  • Rather, they are related to the menu assinged to a Navigatiob block.

Also: I'm not sure what the plans are for the 'manage menus' classic admin page but, so far, some actions are only available on that page. For example, bulk deleting menus. It seems to me this page still has some value. However, the only way to access this page I could find is literally buried down within the inspector and less than discoverable. To access it, users have to:

  • Select a Navigation block.
  • Go to the Block inspector.
  • Switch to the Settings tab (the gear icon).
  • Scroll down to 'Advanced' and expand the panel
  • Click the 'Manage menus' link.

Overall, I'd tend to think this UI isn't in the right place.

  • Ideally, it should be moved to the 'List VIew' tab, where the actual assigned menu lives.
  • The name of the 'List VIew' tab isn't ideal in the first place. While technically it does contain a List View, its actual content is the assigned Menu. It should be renamed to 'Menu'.

Step-by-step reproduction instructions

  • Go to the Site editor and select a Navigation block.
  • Observe the block inspector contains 3 tabs.
  • Observe the first tab is named 'List View' but it actually contains the assigned Menu and also shows a visible H2 heading 'Menu'.
  • Siwtch to the Navigation block Settings tab (the gear icon).
  • Scroll down to 'Advanced' and expand the panel.
  • Observe the panel contains a mini UI that is related to the assigned menu: these are proprties (the name), actions (delete) or links (Manage menus) related to the menu, not to the Navigation block.

Screenshots, screen recording, code snippet

This section arguably belongs to the Navigation block settings:

Screenshot 2024-03-25 at 14 16 20

The almost undiscoverable 'Manage menus' is the only link I could find that provides access to the classig Navigation Menus edit.php page:

manage menu access

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. [Block] Navigation Affects the Navigation Block [Feature] Navigation Menus Any issue relating to Navigation Menus labels Mar 25, 2024
@getdave getdave added [Type] Enhancement A suggestion for improvement. and removed [Type] Bug An existing feature does not function as intended labels Nov 20, 2024
@getdave
Copy link
Contributor

getdave commented Nov 21, 2024

These controls have been available in the Site View under Navigation now for some time. We also have a proposal to use Dataviews to further improve this. As a result I think we can close this Issue.

@getdave getdave closed this as completed Nov 21, 2024
@afercia
Copy link
Contributor Author

afercia commented Nov 22, 2024

These controls have been available in the Site View under Navigation now for some time. We also have a proposal to use Dataviews to further improve this. As a result I think we can close this Issue.

@getdave thanks for your feedback. This issue is about relocating these settings to a better place. Alternatively, remove them when #65828 will be completed.

It doesn't make much sense having these settings related to the menu under the navigation 'Settings':

Image

This impacts usability and accessibility as these settings are little discoverable and the UI is unclear. To me, a fix for an unclear / little usable UI is not an 'enhancement', rather it's a bug. I'm not opposed to close this issue when #65828 will be completed but for now, the issue is still there. Reopening.

@afercia afercia reopened this Nov 22, 2024
@afercia afercia added [Type] Bug An existing feature does not function as intended and removed [Type] Enhancement A suggestion for improvement. labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Feature] Navigation Menus Any issue relating to Navigation Menus Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants