Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination Block: Missing padding, margin, border GUI options (Available/works via theme.json) #69109

Closed
3 of 6 tasks
EldarAgalarov opened this issue Feb 10, 2025 · 3 comments
Closed
3 of 6 tasks

Pagination Block: Missing padding, margin, border GUI options (Available/works via theme.json) #69109

EldarAgalarov opened this issue Feb 10, 2025 · 3 comments
Assignees
@yogeshbhutkar
Labels
[Block] Comment Pagination Next Affects the Comments Pagination Next Block [Block] Comments Pagination Previous Affects the Comments Pagination Previous Block [Block] Query Pagination Affects the Query Pagination Block - used for pagination within the Query Loop Block [Type] Bug An existing feature does not function as intended

Comments

@EldarAgalarov
Copy link

Description

The pagination block is container like group, row and stack blocks but doesn't have GUI options such as padding, margin etc. These options works through a theme.json file.

Step-by-step reproduction instructions

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
@EldarAgalarov EldarAgalarov added the [Type] Bug An existing feature does not function as intended label Feb 10, 2025
@yogeshbhutkar
Copy link
Contributor

This applies to both the Comments Pagination and Pagination blocks. For consistency, we should implement it across both.

A related issue: #67266

@yogeshbhutkar yogeshbhutkar mentioned this issue Feb 10, 2025
Closed
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 10, 2025
@yogeshbhutkar
Copy link
Contributor

After a little research, I found the following Tracking issues:
#43247
#43243

There are separate PRs for both the Comments Pagination and Query Pagination blocks, which are currently under review. I'll be closing my PR in favor of those.

@t-hamano
Copy link
Contributor

Thanks for the report. Since there is already a tracking issue, let's close this PR.

@t-hamano t-hamano added [Block] Query Pagination Affects the Query Pagination Block - used for pagination within the Query Loop Block [Block] Comments Pagination Previous Affects the Comments Pagination Previous Block [Block] Comment Pagination Next Affects the Comments Pagination Next Block and removed [Status] In Progress Tracking issues with work in progress labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yogeshbhutkar yogeshbhutkar

Labels
[Block] Comment Pagination Next Affects the Comments Pagination Next Block [Block] Comments Pagination Previous Affects the Comments Pagination Previous Block [Block] Query Pagination Affects the Query Pagination Block - used for pagination within the Query Loop Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add padding, margin and experimental border support to Pagination block yogeshbhutkar/gutenberg
3 participants
@EldarAgalarov @t-hamano @yogeshbhutkar