-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focused block border color contrast ratio too low #7439
Comments
Can you take a look at the navigation mode solution propose din #5709 (comment)? In that design, navigating through blocks would show the blue outline. |
The blue outline (or any other color with a higher luminosity contrast ratio) would be beneficial. It should be blue also when clicking on the block though. Re: concerns with the blue which is a convention in WordPress: are we sure we want to use a blue? |
Fine, as long as the contrast ratio is at least 3:1 (non-text contrast). Noting this is basically the same issue pointed out in #7053 /Cc @anevins12 |
A general setting for optional high contrast ratio would be beneficial. |
@nbrummerstedt are you suggesting an in general setting for WordPress? I ask as know it can adapt to high contrast settings for example on Windows. |
Come to think of it, such a setting should obviously be a site-wide user-setting. In that case, the suggestion belongs to wordpress/core ? |
@nbrummerstedt that could be possible, core would be the place to suggest such a thing yes. I do wonder though if someone that wanted it would have already set that setting on their computer, that maybe is an assumption. |
@karmatosed As I see it, such a setting should be set on a per user basis, and be disabled by default. A high contrast stylesheet should be enqueued if any of the following :
|
Worth reminding the color contrast ratio should meet the requirement by default, pretty much as the default WordPress admin color scheme aims to do. |
@karmatosed Blue should be fine I think, as long as the demarcation is clear. |
I think I'm right in closing this as we have #5709 suggesting a solution? If I am wrong we can reopen. |
Not sure #5709 will ever get in, as it's a broader issue and currently blocked by a technical problem. Can we try to address the contrast issue separately here? |
When tabbing through the blocks using the keyboard, I can barely see which of the blocks is the focused one. I have some eyesight problem 🙂and I'm not the only one. There are a lot of users with vision impairments who would benefit from a higher contrast ratio.
The low contrast of the border around the focused block is particularly evident when the formatting toolbar is fixed to the top, see screenshot below (hint: the focused block is the second paragraph):
Instead, when the formatting toolbar is attached to the block, the presence of the UI helps a bit but it doesn't fully solve the issue.
I'd propose to consider to increase the gray border contrast. I guess it's not a big visual change, as the contrast when hovering is already way higher. Worth reminding the perceived contrast is not about the shade of color but it's about the luminosity contrast, and the blue used on hover has a way higher luminosity contrast:
Aside:
I'm not fully convinced about the blue, as the convention in WordPress is to use it for actionable controls; regardless, whether the final color will be blue or gray, the luminosity contrast should be higher.
/Cc @jasmussen @karmatosed
The text was updated successfully, but these errors were encountered: