Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview doesn't work when revisions are turned off #7442

Closed
benoitchantre opened this issue Jun 21, 2018 · 1 comment
Closed

Preview doesn't work when revisions are turned off #7442

benoitchantre opened this issue Jun 21, 2018 · 1 comment
Labels
[Feature] Saving Related to saving functionality [Type] Bug An existing feature does not function as intended
Milestone
3.5

Comments

@benoitchantre
Copy link
Contributor

Describe the bug
When revisions are turned off, the preview doesn't work.
The same behaviour occurs when revisions are limited to a number and you have reach the limit.

To Reproduce
Steps to reproduce the behavior:

  1. Turn off revisions
  2. Create a new post or make some changes to an existing one
  3. Do not save the draft or update your post
  4. Try to preview the post
  5. See that you're stuck to "Please wait... Generating preview."

Expected behavior
The preview should be rendered.

Desktop (please complete the following information):

  • OS: macOS 10.3.5
  • Browser: Firefox 60.0.2

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

  • Gutenberg version 3.0.1
@danielbachhuber
Copy link
Member

Related #7348

@danielbachhuber danielbachhuber added this to the 3.2 milestone Jun 22, 2018
@danielbachhuber danielbachhuber added [Type] Bug An existing feature does not function as intended [Feature] Saving Related to saving functionality labels Jun 22, 2018
@danielbachhuber danielbachhuber mentioned this issue Jun 22, 2018
Closed
@gziolo gziolo modified the milestones: 3.2, 3.3 Jul 5, 2018
@aduth aduth modified the milestones: 3.3, 3.4 Jul 18, 2018
@pento pento modified the milestones: 3.4, 3.5 Jul 30, 2018
@danielbachhuber danielbachhuber mentioned this issue Aug 7, 2018
Closed
4 tasks
@adamsilverstein adamsilverstein mentioned this issue Aug 7, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Saving Related to saving functionality [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
3.5
Development

Successfully merging a pull request may close this issue.

Always register the autosaves controller WordPress/gutenberg
5 participants
@danielbachhuber @pento @gziolo @benoitchantre @aduth