Only show submenu options and Show arrow button when relevant. #36826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcanales
force-pushed
the
hide-submenu-options
branch
from
a3cfb2c to
1e5cfa6
Compare
|
This is excellent, thank you! I'll take a look when I have a moment. |
|
Size Change: +998 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
vcanales
changed the title
jasmussen
approved these changes
Nov 25, 2021
| ( select ) => { | ||
| const { getBlocks, hasSelectedInnerBlock } = select( | ||
| blockEditorStore | ||
| ); | ||
| const blocks = getBlocks( clientId ); | ||
| const didFindSubmenu = !! blocks.find( |
There was a problem hiding this comment.
Something about the variable "didFindSubmenu" feels curious to me. Could it just be called "submenus"?
There was a problem hiding this comment.
I didn't use hasSubmenus because that's how I named the variable in the outer scope; I'll go with foundSubmenu, as it describes what the line is doing; using find to figure out if there's at least one submenu present.
|
Looks good, ship it! |
7 tasks
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #36698.
block has at least one Submenu.
Screenshots
Open on click and Show arrow interaction
Edit.Post.Navigation.Menu.gutenberg.WordPress.Mozilla.Firefox.2021-11-24.11-58-12.mp4