Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix customizer block toolbar after popover refactor #41312

Merged
merged 3 commits into from
May 25, 2022
Merged

Fix customizer block toolbar after popover refactor #41312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72ed244
Fix customizer block toolbar after popover refactor
youknowriad May 25, 2022
aa49a73
Fix more popovers
youknowriad May 25, 2022
8a990c8
Fix e2e test
Mamaduka May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/customize-widgets/src/components/sidebar-block-editor/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,14 @@
}

.customize-control-sidebar_block_editor .block-editor-block-list__block-popover {
position: fixed;
// FloatingUI library used in Popover component forces us to have an "absolute" inline style.
// We need to override this in the customizer.
position: fixed !important;
z-index: z-index(".customize-widgets__block-toolbar");
}

.customize-widgets-popover .components-popover {
// FloatingUI library used in Popover component forces us to have an "absolute" inline style.
// We need to override this in the customizer.
position: fixed !important;
}
5 changes: 5 additions & 0 deletions test/e2e/specs/widgets/customizing-widgets.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,11 @@ test.describe( 'Widgets Customizer', () => {
)
).toBeVisible();

// Clear block selection, so the block toolbar isn't visible.
await page.evaluate( () => {
window.wp.data.dispatch( 'core/block-editor' ).clearSelectedBlock();
} );

await widgetsCustomizerPage.addBlock( 'Heading' );
await page.keyboard.type( 'My Heading' );

Expand Down