From fd609691493ddf31acfa220758b9a7d8aaf53d3f Mon Sep 17 00:00:00 2001 From: George Mamadashvili Date: Wed, 3 May 2023 20:55:26 +0400 Subject: [PATCH 1/4] Don't remount the block when the 'templateLock' is set to 'contentOnly' --- packages/block-editor/src/hooks/content-lock-ui.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/block-editor/src/hooks/content-lock-ui.js b/packages/block-editor/src/hooks/content-lock-ui.js index 568da7974925a..9d19b7435a1a1 100644 --- a/packages/block-editor/src/hooks/content-lock-ui.js +++ b/packages/block-editor/src/hooks/content-lock-ui.js @@ -101,7 +101,7 @@ export const withBlockControls = createHigherOrderComponent( ] ); if ( ! isContentLocked && ! isEditingAsBlocks ) { - return ; + return ; } const showStopEditingAsBlocks = isEditingAsBlocks && ! isContentLocked; @@ -157,6 +157,7 @@ export const withBlockControls = createHigherOrderComponent( ) } Date: Wed, 3 May 2023 20:58:03 +0400 Subject: [PATCH 2/4] Remove unused classname --- packages/block-editor/src/hooks/content-lock-ui.js | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/packages/block-editor/src/hooks/content-lock-ui.js b/packages/block-editor/src/hooks/content-lock-ui.js index 9d19b7435a1a1..16055e6317940 100644 --- a/packages/block-editor/src/hooks/content-lock-ui.js +++ b/packages/block-editor/src/hooks/content-lock-ui.js @@ -13,10 +13,6 @@ import { useEffect, useRef, useCallback } from '@wordpress/element'; */ import { store as blockEditorStore } from '../store'; import { BlockControls, BlockSettingsMenuControls } from '../components'; -/** - * External dependencies - */ -import classnames from 'classnames'; function StopEditingAsBlocksOnOutsideSelect( { clientId, @@ -156,15 +152,7 @@ export const withBlockControls = createHigherOrderComponent( ) } ) } - + ); }, From 4234aa5498c802b272057818d54c38f1da839c99 Mon Sep 17 00:00:00 2001 From: George Mamadashvili Date: Wed, 3 May 2023 20:58:29 +0400 Subject: [PATCH 3/4] Fix effect deps --- packages/block-editor/src/hooks/content-lock-ui.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/block-editor/src/hooks/content-lock-ui.js b/packages/block-editor/src/hooks/content-lock-ui.js index 16055e6317940..26779f8d31048 100644 --- a/packages/block-editor/src/hooks/content-lock-ui.js +++ b/packages/block-editor/src/hooks/content-lock-ui.js @@ -33,7 +33,7 @@ function StopEditingAsBlocksOnOutsideSelect( { if ( ! isBlockOrDescendantSelected ) { stopEditingAsBlock(); } - }, [ isBlockOrDescendantSelected ] ); + }, [ isBlockOrDescendantSelected, stopEditingAsBlock ] ); return null; } From ca0dd6bce17708f7ef52c87675c35f744382075d Mon Sep 17 00:00:00 2001 From: George Mamadashvili Date: Wed, 3 May 2023 22:41:13 +0400 Subject: [PATCH 4/4] Remove focusModeToRevert from deps --- packages/block-editor/src/hooks/content-lock-ui.js | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/block-editor/src/hooks/content-lock-ui.js b/packages/block-editor/src/hooks/content-lock-ui.js index 26779f8d31048..c1cf7016bfd44 100644 --- a/packages/block-editor/src/hooks/content-lock-ui.js +++ b/packages/block-editor/src/hooks/content-lock-ui.js @@ -87,7 +87,6 @@ export const withBlockControls = createHigherOrderComponent( __unstableSetTemporarilyEditingAsBlocks(); }, [ props.clientId, - focusModeToRevert, updateSettings, updateBlockListSettings, getBlockListSettings,