Remove gutenberg_should_block_use_interactivity_api and the old implementation of interactive blocks
#54297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
requested review from
spacedmonkey,
tellthemachines and
ajitbohra
as code owners
SantosGuillamot
added
[Block] File
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/experimental/blocks.php |
SantosGuillamot
added
the
[Type] Code Quality
|
Size Change: -3.69 kB (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
24 tasks
|
Flaky tests detected in 9a1eb73. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6122352352
|
SantosGuillamot
requested review from
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
An additional disclaimer for anyone seeing this PR: the version of the Interactivity API that we plan to merge with 6.4 will be private to Core blocks and still subject to change (or even be reverted if necessary). More info here: |
luisherranz
approved these changes
Sep 8, 2023
|
@westonruter: now that we plan to proceed with this plan for the Interactivity API in WP 6.4, we are removing the |
SantosGuillamot
deleted the
update/remove-old-implementation-interactive-blocks
branch
|
I just merged this pull request because it is blocking the package sync settings. @westonruter if you have any concerns I'm happy to revert these changes or work on an alternative. Just let me know 🙂 |
|
I guess the only problem is that any minor releases between now and 6.4 won't be able to update the |
|
I thought those minor releases didn't use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove the
gutenberg_should_block_use_interactivity_apifunction and the conditionals using it. Additionally, I took the opportunity to remove the old implementation of blocks using the Interactivity API.Why?
Now that we are planning on using the Interactivity API in both WordPress 6.4 and Gutenberg, we don't need to keep supporting the old versions.
How?
I just removed the function that was checking if it was in Gutenberg and I removed the conditionals to ensure they work the same way in WordPress and Gutenberg.
Additionally, I reverted the changes made here to only have the Interactivity API version.
Testing Instructions
view.jsfile with the Interactivity API code, and check that the overlay menu and the submenu work as expected.view.jsfile with the Interactivity API, and check it shows the preview when the setting is activated.