Patterns: Use slug as fallback for empty title #54731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +13 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Thank you, @t-hamano!
All the changes test well for me ✅
Cc-ing @aaronrobertshaw and @glendaviesnz for visibility.
|
Thanks for the review, @Mamaduka! |
ntsekouras
approved these changes
Sep 22, 2023
|
I just cherry-picked this PR to the release/16.7 branch to get it included in the next release: cb39b6f |
mikachan
removed
the
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recloses #54693
What?
This PR solves the following problem by using a slug as a fallback when the pattern doesn't have a title.
json.jsonWhy?
In #54717, it is now required to enter a title when creating a pattern. However, by accessing
edit.php?post_type=wp_block, you can update the title to empty just like a normal post.Therefore, we need a fallback that assumes the title is empty.
How?
If there is no title for the pattern, use the slug.
Testing Instructions
Preparation
Title in the Patterns Library
Delete Pattern
Note: Attempt to delete the pattern, but do not actually delete it.
Are you sure you want to delete ""?.Are you sure you want to delete "my-pattern"?.Duplicate Pattern
"" duplicated.and the new pattern title should display as(Copy)."{slug}" duplicated.should be displayed and the new pattern title should be displayed as{slug} (Copy).Exporting Pattern
json.json.{slug}.json.Import Pattern