Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use allow-list for mobile editor settings endpoint #56424

Draft
wants to merge 11 commits into
base: trunk
Choose a base branch
from
Draft

Use allow-list for mobile editor settings endpoint #56424

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
16e6185
Use allow-list for mobile editor settings endpoint
mkevins Nov 22, 2023
f65e77a
refactor: Format php
dcalhoun Nov 22, 2023
df2b3d5
refactor: Guard mobile allow list utility against redeclaration
dcalhoun Nov 22, 2023
3e4a8c1
fix: Avoid error from selecting non-existent settings key
dcalhoun Nov 22, 2023
a4995db
fix: Add `__experimentalStyles` key to the allow list
dcalhoun Nov 22, 2023
8f072e3
Rename mobile settings allow-list filter function
mkevins Nov 23, 2023
7f3d705
Extract mobile editor settings allow list to a constant
mkevins Nov 23, 2023
9c19187
Remove experimental dashboard link from the mobile allow list
mkevins Nov 23, 2023
ce92b82
Extract mobile editor settings filter to a separate file
mkevins Nov 24, 2023
0a1e7bd
Load mobile-specific filter for the editor settings endpoint
mkevins Nov 24, 2023
a7cb39f
refactor: Format php
dcalhoun Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/experimental/block-editor-settings-mobile.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ function keep_supported_block_editor_settings_mobile( $initial_array, $allow_lis
$result = array();

foreach ( $allow_list_array as $key => $value ) {
if ( ! array_key_exists( $key, $initial_array ) ) {
continue;
}

$initial_value = $initial_array[ $key ];

if ( array_key_exists( $key, $initial_array ) ) {
Expand Down