-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Unify context text cursor preference #57479
Conversation
Size Change: +7 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise this looks good. I think we should settle though on the used scope first - whether use edit-post
or something related to the editor
package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my testing, if I have this setting turned on in either editor, and off it the other, this change enables it in both. I think this is probably the best way to handle this scenario, but just wanted to raise it.
b0dc541
to
b4922c4
Compare
This has been rebased and includes the migration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well for me, and code is consistent with the other PRs.
- When loading either editor, my value for this preference from the post editor is used.
- The preference operates across both site and post editors.
- The migration worked correctly.
b4922c4
to
70550fb
Compare
Related #52632
Similar to #57468
What?
This PR continues the work on the great unification between post and site editors. In this PR we're unifying the "contain text cursor inside block" preference. If the user enables it in the post editor, the setting should be used in the site editor as well.
Testing instructions