From dc0bf330414662e3cf82aea4e977447539e89aae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dami=C3=A1n=20Su=C3=A1rez?= Date: Thu, 2 May 2024 19:38:05 +0100 Subject: [PATCH 1/6] do not render label elements when undedined --- packages/components/src/form-token-field/index.tsx | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/packages/components/src/form-token-field/index.tsx b/packages/components/src/form-token-field/index.tsx index c7ec536e90eff..d89080b4410c4 100644 --- a/packages/components/src/form-token-field/index.tsx +++ b/packages/components/src/form-token-field/index.tsx @@ -694,12 +694,14 @@ export function FormTokenField( props: FormTokenFieldProps ) { /* eslint-disable jsx-a11y/no-static-element-interactions */ return (
- - { label } - + { label && ( + + { label } + + ) }
Date: Mon, 6 May 2024 08:57:19 +0100 Subject: [PATCH 2/6] changelog --- packages/components/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index d8263245eebf2..221c8eb96a27d 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -15,6 +15,7 @@ - `View`: Fix prop types ([#60919](https://github.com/WordPress/gutenberg/pull/60919)). - `Placeholder`: Unify appearance across. ([#59275](https://github.com/WordPress/gutenberg/pull/59275)). - `Toolbar`: Adjust top toolbar to use same metrics as block toolbar ([#61126](https://github.com/WordPress/gutenberg/pull/61126)). +- `FormTokenField`: Hide component label when not defined ([#61395](https://github.com/WordPress/gutenberg/pull/61336)). ### Bug Fix From e0c125b628e9e37947298279c2487a4a5a87cbd8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dami=C3=A1n=20Su=C3=A1rez?= Date: Mon, 6 May 2024 09:27:50 +0100 Subject: [PATCH 3/6] tweak changelog --- packages/components/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index 221c8eb96a27d..3df535073ccf9 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -10,12 +10,12 @@ ### Enhancements +- `FormTokenField`: Hide label when not defined ([#61395](https://github.com/WordPress/gutenberg/pull/61336)). - Replaced `classnames` package with the faster and smaller `clsx` package ([#61138](https://github.com/WordPress/gutenberg/pull/61138)). - `InputControl`: Add a password visibility toggle story ([#60898](https://github.com/WordPress/gutenberg/pull/60898)). - `View`: Fix prop types ([#60919](https://github.com/WordPress/gutenberg/pull/60919)). - `Placeholder`: Unify appearance across. ([#59275](https://github.com/WordPress/gutenberg/pull/59275)). - `Toolbar`: Adjust top toolbar to use same metrics as block toolbar ([#61126](https://github.com/WordPress/gutenberg/pull/61126)). -- `FormTokenField`: Hide component label when not defined ([#61395](https://github.com/WordPress/gutenberg/pull/61336)). ### Bug Fix From 2797345d0578f364cbb7dca5559df3f908fbeca7 Mon Sep 17 00:00:00 2001 From: Alex Stine Date: Mon, 6 May 2024 22:48:02 -0500 Subject: [PATCH 4/6] Update packages/components/CHANGELOG.md --- packages/components/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index 3df535073ccf9..f7a8378aa0eeb 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -10,7 +10,7 @@ ### Enhancements -- `FormTokenField`: Hide label when not defined ([#61395](https://github.com/WordPress/gutenberg/pull/61336)). +- `FormTokenField`: Hide label when not defined ([#61336(https://github.com/WordPress/gutenberg/pull/61336)). - Replaced `classnames` package with the faster and smaller `clsx` package ([#61138](https://github.com/WordPress/gutenberg/pull/61138)). - `InputControl`: Add a password visibility toggle story ([#60898](https://github.com/WordPress/gutenberg/pull/60898)). - `View`: Fix prop types ([#60919](https://github.com/WordPress/gutenberg/pull/60919)). From cf2e02e167c3e8e38af2b406896f94e0bc891c26 Mon Sep 17 00:00:00 2001 From: Alex Stine Date: Mon, 6 May 2024 22:52:04 -0500 Subject: [PATCH 5/6] Update packages/components/CHANGELOG.md --- packages/components/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index f7a8378aa0eeb..bfc954581fab5 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -10,7 +10,7 @@ ### Enhancements -- `FormTokenField`: Hide label when not defined ([#61336(https://github.com/WordPress/gutenberg/pull/61336)). +- `FormTokenField`: Hide label when not defined ([#61336](https://github.com/WordPress/gutenberg/pull/61336)). - Replaced `classnames` package with the faster and smaller `clsx` package ([#61138](https://github.com/WordPress/gutenberg/pull/61138)). - `InputControl`: Add a password visibility toggle story ([#60898](https://github.com/WordPress/gutenberg/pull/60898)). - `View`: Fix prop types ([#60919](https://github.com/WordPress/gutenberg/pull/60919)). From f960d4cc9ced0fabb49d55559d6b995867a3ce2a Mon Sep 17 00:00:00 2001 From: Alex Stine Date: Wed, 8 May 2024 00:34:54 -0500 Subject: [PATCH 6/6] Move changelog entry to unreleased. --- packages/components/CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index 30b03c768945d..fa2e6ac57d176 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -7,13 +7,14 @@ - Replaced `classnames` package with the faster and smaller `clsx` package ([#61138](https://github.com/WordPress/gutenberg/pull/61138)). ### Enhancements + - `PaletteEdit`: Use consistent spacing and metrics. ([#61368](https://github.com/WordPress/gutenberg/pull/61368)). +- `FormTokenField`: Hide label when not defined ([#61336](https://github.com/WordPress/gutenberg/pull/61336)). ## 27.5.0 (2024-05-02) ### Enhancements -- `FormTokenField`: Hide label when not defined ([#61336](https://github.com/WordPress/gutenberg/pull/61336)). - Replaced `classnames` package with the faster and smaller `clsx` package ([#61138](https://github.com/WordPress/gutenberg/pull/61138)). - `InputControl`: Add a password visibility toggle story ([#60898](https://github.com/WordPress/gutenberg/pull/60898)). - `View`: Fix prop types ([#60919](https://github.com/WordPress/gutenberg/pull/60919)).