-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sorting by name or count in categories block #66453
Open
SantosGuillamot
wants to merge
6
commits into
trunk
Choose a base branch
from
feature/add-sorting-by-name-or-count-in-categories-block
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+60
−4
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e984c6f
Add block attributes
SantosGuillamot 5289612
Order in the editor
SantosGuillamot 43f30bc
Order in the frontend
SantosGuillamot 2659163
Fix `orderby` in query
SantosGuillamot 1538f96
Change default query
SantosGuillamot bcc3a09
Regenerate fixtures
SantosGuillamot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,6 +35,8 @@ export default function CategoriesEdit( { | |
label, | ||
showLabel, | ||
taxonomy: taxonomySlug, | ||
order, | ||
orderBy, | ||
}, | ||
setAttributes, | ||
className, | ||
|
@@ -53,7 +55,13 @@ export default function CategoriesEdit( { | |
const isHierarchicalTaxonomy = | ||
! isResolvingTaxonomies && taxonomy?.hierarchical; | ||
|
||
const query = { per_page: -1, hide_empty: ! showEmpty, context: 'view' }; | ||
const query = { | ||
per_page: -1, | ||
hide_empty: ! showEmpty, | ||
context: 'view', | ||
order, | ||
orderby: orderBy, | ||
}; | ||
if ( isHierarchicalTaxonomy && showOnlyTopLevel ) { | ||
query.parent = 0; | ||
} | ||
|
@@ -181,6 +189,29 @@ export default function CategoriesEdit( { | |
className: classes, | ||
} ); | ||
|
||
const orderOptions = [ | ||
{ | ||
/* translators: label for ordering taxonomies by number of posts in descending order */ | ||
label: __( 'Highest #' ), | ||
value: 'count/desc', | ||
}, | ||
{ | ||
/* translators: label for ordering taxonomies by number of posts in ascending order */ | ||
label: __( 'Lowest #' ), | ||
value: 'count/asc', | ||
}, | ||
Comment on lines
+193
to
+202
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wasn't sure how to label these options. |
||
{ | ||
/* translators: label for ordering taxonomies by name in ascending order */ | ||
label: __( 'A → Z' ), | ||
value: 'name/asc', | ||
}, | ||
{ | ||
/* translators: label for ordering taxonomies by name in descending order */ | ||
label: __( 'Z → A' ), | ||
value: 'name/desc', | ||
}, | ||
]; | ||
|
||
return ( | ||
<TagName { ...blockProps }> | ||
<InspectorControls> | ||
|
@@ -202,6 +233,20 @@ export default function CategoriesEdit( { | |
} | ||
/> | ||
) } | ||
<SelectControl | ||
__nextHasNoMarginBottom | ||
__next40pxDefaultSize | ||
label={ __( 'Order by' ) } | ||
options={ orderOptions } | ||
value={ `${ orderBy }/${ order }` } | ||
onChange={ ( value ) => { | ||
const [ newOrderBy, newOrder ] = value.split( '/' ); | ||
setAttributes( { | ||
orderBy: newOrderBy, | ||
order: newOrder, | ||
} ); | ||
} } | ||
/> | ||
<ToggleControl | ||
__nextHasNoMarginBottom | ||
label={ __( 'Display as dropdown' ) } | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept the default query to prevent unexpected results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was also wondering if we should create a
query
attribute like the query loop has and include properties there liketaxonomy
. But I am not sure how it would work with backward compatibility.