Storybook: Log warning() when in dev mode
#66568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Developer Documentation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.81 MB ℹ️ View Unchanged
|
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: mirka <[email protected]> Co-authored-by: tyxla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Ensure that console warnings using
@wordpress/warningare also properly logged in Storybook when in dev mode.Why?
warning()messages were not logged in Storybook, even when in dev mode. This is inconvenient because we often check for these things using Storybook.How?
warning()checks for dev mode using theSCRIPT_DEBUGglobal.gutenberg/packages/warning/src/index.ts
Lines 6 to 9 in 7714bce
We should inject this with Webpack, similar to how the wp packages are built:
gutenberg/tools/webpack/shared.js
Line 75 in 7714bce
Testing Instructions
See the "With Actions" story for Snackbar. Adding multiple actions to the
actionsarray should log a console warning.gutenberg/packages/components/src/snackbar/index.tsx
Lines 119 to 123 in 7714bce
Alter the story args here so there are multiple actions:
gutenberg/packages/components/src/snackbar/stories/index.story.tsx
Lines 59 to 64 in 7714bce