-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a feature to set alpha value to Highlight #67525
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Could someone please take a look at this pull request? 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply.
This feature works well and I think it's ready to ship. I think it's very useful when you want to apply a soft background color that blends in a bit with the text:
I re-read #34680 where the background color feature was implemented, but there was no specific mention of any concerns about adding alpha color.
One thing to note is that alpha color will be available for both text color and background color.
I believe this is a very important change and would like to solicit additional feedback. cc @WordPress/gutenberg-core
What design feedback is exactly needed? |
What?
fix #67453
Add a feature to set alpha value to Highlight
Why?
Being able to set alpha color expands the range of design possibilities!
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
textcoloralpha.mp4