Skip to content
This repository has been archived by the owner on Oct 28, 2022. It is now read-only.

Update query block markup and crop featured images #165

Merged
merged 4 commits into from
Sep 19, 2022

Conversation

mikachan
Copy link
Member

@mikachan mikachan commented Sep 13, 2022

This PR addresses a few issues noticed while demoing the theme, listed in #164.

  • Fixes the query pagination on the home template (the pagination block was outside of the query block)
  • Changes the home and index query blocks to a default layout, allowing them to fill the align wide width (no longer needed with this fix Fix alignments for children of Query block. gutenberg#44144)
  • Crops the featured images on the home, index, search, and archive templates, to help keep the images and titles aligned within the query block

Cropped featured images:

Before After
image image

@mikachan mikachan added [Type] Bug Something isn't working [Type] Enhancement New feature or request labels Sep 13, 2022
@mikachan mikachan linked an issue Sep 13, 2022 that may be closed by this pull request
Copy link
Member

@madhusudhand madhusudhand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well with different image sizes. LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug Something isn't working [Type] Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues running into while demoing
2 participants