Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm packages to latest versions for 6.4 RC3 v2 #5610

Closed
wants to merge 1 commit into from

Conversation

mikachan
Copy link
Member

@mikachan mikachan commented Nov 1, 2023

@hellofromtonya hellofromtonya self-requested a review November 1, 2023 17:01
@hellofromtonya
Copy link
Contributor

Pulling down the commit to test.

@hellofromtonya
Copy link
Contributor

No console or PHP errors when applied locally. Next step: commit to trunk.

Copy link
Contributor

@hellofromtonya hellofromtonya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Marking for commit.

* rendering when a plugin block has been found inside. It does so
* by adding an attribute called `data-wp-navigation-disabled` which
* is later handled by the front-end logic.
*
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should filter comment have a since tag?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in Make/Core slack

The files in wp-includes/blocks are maintained by Gutenberg, not by Core. Very few of the functions in this directory include an @since annotation. It would good to open an issue in Gutenberg to discuss adding the annotation to all of the functions, filters, callbacks, etc. within this directory.

@hellofromtonya
Copy link
Contributor

@mikachan mikachan deleted the gb-sync-6.4-rc3-2 branch November 1, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants